Issue 6711017: Update OOM killer.

Issue 6711017: Update OOM killer. (Closed)

Created:
9 years, 9 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update OOM killer. BUG=74589 TEST=unit tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78702

Patch Set 5 : address feedback #

Total comments: 6

Patch Set 6 : update #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -19 lines)			Patch
M	base/process_util_mac.mm	View	1 2 3 4 5	3 chunks	+42 lines, -15 lines	0 comments	Download
M	third_party/apple_apsl/CFBase.h	View	1 2 3 4 5	2 chunks	+26 lines, -3 lines	0 comments	Download
M	third_party/apple_apsl/README.chromium	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

http://codereview.chromium.org/6711017/diff/3001/base/process_util_mac.mm File base/process_util_mac.mm (right): http://codereview.chromium.org/6711017/diff/3001/base/process_util_mac.mm#newcode639 base/process_util_mac.mm:639: ChromeCFAllocator11* our_allocator = Warn as discussed? http://codereview.chromium.org/6711017/diff/3001/third_party/apple_apsl/CFBase.h File third_party/apple_apsl/CFBase.h ...

9 years, 9 months ago (2011-03-17 21:37:44 UTC) #2

Avi (use Gerrit)

here ya go http://codereview.chromium.org/6711017/diff/3001/base/process_util_mac.mm File base/process_util_mac.mm (right): http://codereview.chromium.org/6711017/diff/3001/base/process_util_mac.mm#newcode639 base/process_util_mac.mm:639: ChromeCFAllocator11* our_allocator = On 2011/03/17 21:37:44, ...

9 years, 9 months ago (2011-03-17 22:09:17 UTC) #3

Mark Mentovai

LGTM http://codereview.chromium.org/6711017/diff/6001/base/process_util_mac.mm File base/process_util_mac.mm (right): http://codereview.chromium.org/6711017/diff/6001/base/process_util_mac.mm#newcode626 base/process_util_mac.mm:626: // TODO(avi):remove at final release; http://crbug.com/74589 Space after ...

9 years, 9 months ago (2011-03-17 23:10:46 UTC) #4

Mark Mentovai

http://codereview.chromium.org/6711017/diff/6001/base/process_util_mac.mm File base/process_util_mac.mm (right): http://codereview.chromium.org/6711017/diff/6001/base/process_util_mac.mm#newcode628 base/process_util_mac.mm:628: NSLog(@"Unsure about the internals of CFAllocator but going to ...

9 years, 9 months ago (2011-03-17 23:18:51 UTC) #5

Avi (use Gerrit)

http://codereview.chromium.org/6711017/diff/6001/base/process_util_mac.mm File base/process_util_mac.mm (right): http://codereview.chromium.org/6711017/diff/6001/base/process_util_mac.mm#newcode626 base/process_util_mac.mm:626: // TODO(avi):remove at final release; http://crbug.com/74589 On 2011/03/17 23:10:46, ...

9 years, 9 months ago (2011-03-18 13:18:35 UTC) #6

Good stuff, LGTM.

Expand Messages | Collapse Messages