ui/base/ime/composition.cc - Issue 6711008: Add common data types for input method support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/ime/composition.cc

Issue 6711008: Add common data types for input method support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/base/ime/composition.h"

	6

	7 namespace ui {

	8
	Peng 2011/03/18 18:01:11 It is better to put those struct's functions in he It is better to put those struct's functions in header file, and remove this file? James Su 2011/03/18 18:11:24 According to chromium code style, we shouldn't inl Show quoted text On 2011/03/18 18:01:11, Peng wrote: > It is better to put those struct's functions in header file, and remove this > file? According to chromium code style, we shouldn't inline constructors. Peng 2011/03/18 18:50:11 But it still looks not much reasonable for me, to But it still looks not much reasonable for me, to add a .cc file for a such simple struct. Maybe you should use class instead of struct to emphasize this is not a struct, it has some member functions. On 2011/03/18 18:11:24, James Su wrote: Show quoted text > On 2011/03/18 18:01:11, Peng wrote: > > It is better to put those struct's functions in header file, and remove this > > file? > > According to chromium code style, we shouldn't inline constructors. James Su 2011/03/18 19:18:35 Just removed it. We actually don't need it. Show quoted text On 2011/03/18 18:50:11, Peng wrote: > But it still looks not much reasonable for me, to add a .cc file for a such > simple struct. Maybe you should use class instead of struct to emphasize this is > not a struct, it has some member functions. > > On 2011/03/18 18:11:24, James Su wrote: > > On 2011/03/18 18:01:11, Peng wrote: > > > It is better to put those struct's functions in header file, and remove this > > > file? > > > > According to chromium code style, we shouldn't inline constructors. > Just removed it. We actually don't need it.
	9 Composition::Composition() {

	10 }

	11

	12 void Composition::Clear() {

	13 text.clear();

	14 underlines.clear();

	15 selection = Range();

	16 }

	17

	18 } // namespace ui

OLD	NEW

« ui/base/ime/composition.h ('K') | « ui/base/ime/composition.h ('k') | ui/base/ime/composition_underline.h » ('j') | ui/base/ime/composition_underline.h » ('J')