Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 67109: Fix the source position recorded for funtion return (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix the source position recorded for funtion return Record the function return position as the end of the function source. Don't record function entry and return positions as statement positions. Added a test for source position for break at function return. Committed: http://code.google.com/p/v8/source/detail?r=1706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -11 lines) Patch
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 7 chunks +58 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-13 23:03:01 UTC) #1
Kevin Millikin (Chromium)
*Ouch*, that was some pretty careless copy and paste on my part. It looks like ...
11 years, 8 months ago (2009-04-14 07:44:44 UTC) #2
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-14 14:57:31 UTC) #3
On 2009/04/14 07:44:44, Kevin Millikin wrote:
> *Ouch*, that was some pretty careless copy and paste on my part.
> 
> It looks like we're still recording start and return as statement positions?

When doing this change I tried to remove the statement position recording for
these, but it caused assertions for the deferred code generation, so I left it
in. I will try to address it at some point.

Powered by Google App Engine
This is Rietveld 408576698