Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 671023: Add support to auto-shutdown on lid close if no one is logged in (Closed)

Created:
10 years, 9 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add support to auto-shutdown on lid close if no one is logged in Since there should be no background processing going on and boot is fast, we shouldn't waste battery sleeping when no one is logged in. This is implemented using simple state files and upstart events. It is simplistic but minimizes suspend dependencies at the cost of some minor login+lid-close raciness. As a side benefit, this ensures that if a user types in a passphrase, then shuts the lid before pressing enter, the password won't stay resident in the password box for the next person that opens it. BUG=1780 TEST=none

Patch Set 1 #

Total comments: 2

Patch Set 2 : stop on ui stopped not stopping #

Patch Set 3 : remove the deprecated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M src/platform/acpi/action_lid.sh View 1 chunk +6 lines, -0 lines 0 comments Download
A src/platform/init/login.conf View 1 chunk +15 lines, -0 lines 0 comments Download
A src/platform/init/logout.conf View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M src/platform/init/ui.conf View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Will Drewry
10 years, 9 months ago (2010-03-08 22:24:44 UTC) #1
Chris Masone
http://codereview.chromium.org/671023/diff/1/4 File src/platform/init/logout.conf (right): http://codereview.chromium.org/671023/diff/1/4#newcode8 src/platform/init/logout.conf:8: # TODO(wad) should this be triggered on stopped ui ...
10 years, 9 months ago (2010-03-08 22:32:20 UTC) #2
Will Drewry
http://codereview.chromium.org/671023/diff/1/4 File src/platform/init/logout.conf (right): http://codereview.chromium.org/671023/diff/1/4#newcode8 src/platform/init/logout.conf:8: # TODO(wad) should this be triggered on stopped ui ...
10 years, 9 months ago (2010-03-08 22:56:14 UTC) #3
Chris Masone
10 years, 9 months ago (2010-03-08 23:00:20 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698