All platforms don't support same locales at the same time. Make locale check ...

chrome/common/extensions/extension_l10n_util.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_l10n_util.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/linked_ptr.h"
+#include "base/logging.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_message_bundle.h"
 #include "chrome/common/json_value_serializer.h"
 #include "chrome/common/url_constants.h"
 #include "unicode/uloc.h"
 
@@ skipping 116 matching lines @@
 bool AddLocale(const std::set<std::string>& chrome_locales,
                const FilePath& locale_folder,
                const std::string& locale_name,
                std::set<std::string>* valid_locales,
                std::string* error) {
   // Accept name that starts with a . but don't add it to the list of supported
   // locales.
   if (locale_name.find(".") == 0)
     return true;
   if (chrome_locales.find(locale_name) == chrome_locales.end()) {
-    // Fail if there is an extension locale that's not in the Chrome list.
-    *error = StringPrintf("Supplied locale %s is not supported.",
-                          locale_name.c_str());
-    return false;
+    // Warn if there is an extension locale that's not in the Chrome list,
+    // but don't fail.
+    LOG(WARNING) << StringPrintf("Supplied locale %s is not supported.",
+                                 locale_name.c_str());
+    return true;
   }
   // Check if messages file is actually present (but don't check content).
   if (file_util::PathExists(
       locale_folder.Append(Extension::kMessagesFilename))) {
     valid_locales->insert(locale_name);
   } else {
     *error = StringPrintf("Catalog file is missing for locale %s.",
                           locale_name.c_str());
     return false;
   }
@@ skipping 25 matching lines @@
   base::strlcpy(parent, locale.c_str(), kNameCapacity);
   parent_locales->push_back(parent);
   UErrorCode err = U_ZERO_ERROR;
   while (uloc_getParent(parent, parent, kNameCapacity, &err) > 0) {
     if (U_FAILURE(err))
       break;
     parent_locales->push_back(parent);
   }
 }
 
-// Extends list of Chrome locales to them and their parents, so we can do
-// proper fallback.
-static void GetAllLocales(std::set<std::string>* all_locales) {
+void GetAllLocales(std::set<std::string>* all_locales) {
   const std::vector<std::string>& available_locales =
       l10n_util::GetAvailableLocales();
   // Add all parents of the current locale to the available locales set.
   // I.e. for sr_Cyrl_RS we add sr_Cyrl_RS, sr_Cyrl and sr.
   for (size_t i = 0; i < available_locales.size(); ++i) {
     std::vector<std::string> result;
     GetParentLocales(available_locales[i], &result);
     all_locales->insert(result.begin(), result.end());
   }
 }
@@ skipping 21 matching lines @@
     }
   }
 
   if (valid_locales->empty()) {
     *error = extension_manifest_errors::kLocalesNoValidLocaleNamesListed;
     return false;
   }
 
   return true;
 }
-
 // Loads contents of the messages file for given locale. If file is not found,
 // or there was parsing error we return NULL and set |error|.
 // Caller owns the returned object.
 static DictionaryValue* LoadMessageFile(const FilePath& locale_path,
                                         const std::string& locale,
                                         std::string* error) {
   std::string extension_locale = locale;
   FilePath file = locale_path.AppendASCII(extension_locale)
       .Append(Extension::kMessagesFilename);
   JSONFileValueSerializer messages_serializer(file);
@@ skipping 32 matching lines @@
       // an error.
       return false;
     } else {
       catalogs.push_back(catalog);
     }
   }
 
   return ExtensionMessageBundle::Create(catalogs, error);
 }
 
+bool ShouldSkipValidation(const FilePath& locales_path,
+                          const FilePath& locale_path,
+                          const std::set<std::string>& all_locales) {
+  // Since we use this string as a key in a DictionaryValue, be paranoid about
+  // skipping any strings with '.'. This happens sometimes, for example with
+  // '.svn' directories.
+  FilePath relative_path;
+  if (!locales_path.AppendRelativePath(locale_path, &relative_path))
+    NOTREACHED();
+  std::wstring subdir(relative_path.ToWStringHack());
+  if (std::find(subdir.begin(), subdir.end(), L'.') != subdir.end())
+    return true;
+
+  if (all_locales.find(WideToASCII(subdir)) == all_locales.end())
+    return true;
+
+  return false;
+}
+
 }  // namespace extension_l10n_util