Querying the history service to get the redirect information for urls....

chrome/browser/safe_browsing/malware_details_history.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Implementation of the MalwareDetailsRedirectsCollector class.
+
+#include "chrome/browser/safe_browsing/malware_details_history.h"
+
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/safe_browsing/malware_details.h"
+#include "content/browser/browser_thread.h"
+#include "content/browser/renderer_host/render_view_host.h"
+#include "content/browser/tab_contents/navigation_entry.h"
+#include "content/browser/tab_contents/tab_contents.h"
+
+
+MalwareDetailsRedirectsCollector::MalwareDetailsRedirectsCollector()
+    : history_(NULL),
+      has_started_(false) {
+}
+
+MalwareDetailsRedirectsCollector::~MalwareDetailsRedirectsCollector() {
+}
+
+void MalwareDetailsRedirectsCollector::StartHistoryCollection(
+    const std::vector<GURL>& urls,
+    TabContents* tab_contents,
+    Task* callback) {
+  LOG(INFO) << "Num of urls: " << urls.size();
+  tab_contents_ = tab_contents;
+  has_started_ = true;
+  callback_ = callback;
+
+  if (urls.size() == 0) {
+    AllDone();
+    return;
+  }
+
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      NewRunnableMethod(
+          this, &MalwareDetailsRedirectsCollector::StartGetRedirects, urls));
+}
+
+void MalwareDetailsRedirectsCollector::StartGetRedirects(
+        const std::vector<GURL>& urls) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  // History access need to happen in UI thread

[mattm, 2011/05/17 03:17:01]

The HistoryService class comment says it is threadsafe.

Maybe you need to be on UI thread to get the history from the profile? (It
doesn't seem to have any comments regarding thread safety.)

[kewang, 2011/05/18 05:47:40]

yes, when access history service from profile, it need to be in UI thread,
otherwise fail with error msg:

FATAL:pref_service.cc(330)] Check failed: CalledOnValidThread(). 

+  if (history_ == NULL) {
+    LOG(INFO) << "Getting access to history service";
+    history_ = tab_contents_->profile()->GetHistoryService(
+        Profile::EXPLICIT_ACCESS);
+  }
+
+  if (history_ == NULL) {
+    LOG(INFO) << "Could not access history service.";
+    AllDone();
+    return;
+  }
+
+  for (uint i = 0; i < urls.size(); ++i)

[mattm, 2011/05/17 03:17:01]

size_t (other places too)

[kewang, 2011/05/18 05:47:40]

Done.

+    urls_.push_back(urls[i]);
+  urls_it_ = urls_.begin();
+
+  GetRedirects(*urls_it_);
+}
+
+void MalwareDetailsRedirectsCollector::GetRedirects(const GURL& url) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  CancelableRequestConsumer* request_consumer =
+      new CancelableRequestConsumer();

[mattm, 2011/05/17 03:17:01]

This will be leaked.  It should be a class member.

[kewang, 2011/05/18 05:47:40]

Done.

+
+  history_->QueryRedirectsTo(
+      url,
+      request_consumer,
+      NewCallback(this,
+                  &MalwareDetailsRedirectsCollector::OnGotQueryRedirectsTo));
+}
+
+void MalwareDetailsRedirectsCollector::OnGotQueryRedirectsTo(
+    HistoryService::Handle handle,
+    GURL url,
+    bool success,
+    history::RedirectList* redirect_list) {
+
+    if (success && redirect_list->size() > 0) {

[mattm, 2011/05/17 03:17:01]

wrong indentation

[kewang, 2011/05/18 05:47:40]

Done.

+      std::vector<GURL> urllist;
+      urllist.push_back(url);
+      for (uint i = 0; i < redirect_list->size(); i++) {
+        urllist.push_back(redirect_list->at(i));
+      }
+      redirects_urls_.push_back(urllist);
+    }
+
+    // Proceed to next url
+    ++urls_it_;
+
+    if (urls_it_ == urls_.end()) {
+      AllDone();
+      return;
+    }
+
+  GetRedirects(*urls_it_);
+}
+
+bool MalwareDetailsRedirectsCollector::HasStarted() {
+  return has_started_;
+}
+
+void MalwareDetailsRedirectsCollector::AllDone() {
+  DVLOG(1) << "AllDone";
+  BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_);
+}
+
+std::vector<safe_browsing::RedirectChain>*
+MalwareDetailsRedirectsCollector::GetCollectedUrls() {
+  return &redirects_urls_;
+}
+
+void MalwareDetailsRedirectsCollector::SetHistory(HistoryService* history) {
+  history_ = history;
+}
+