Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 6709028: Revert r7258 and r7260. (Closed)

Created:
9 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Revert r7258 and r7260. They apparently break Threading tests on at least Mac and Win64. TBR=vitalyr@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -269 lines) Patch
M src/api.cc View 4 chunks +22 lines, -24 lines 0 comments Download
M src/handles.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/messages.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/top.h View 3 chunks +4 lines, -50 lines 0 comments Download
M src/top.cc View 3 chunks +20 lines, -35 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +1 line, -131 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
9 years, 9 months ago (2011-03-18 13:31:21 UTC) #1
Vitaly Repeshko
9 years, 9 months ago (2011-03-18 13:32:44 UTC) #2
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698