Move some common ime code to ui/base/

Move chrome/browser/ime_input.* to ui/base/win/
Move ExtractCompositionInfo method in chrome/browser/renderer_host/gtk_im_context_wrapper.cc to ui/base/gtk/gtk_im_context_util.cc

BUG=75003
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79214

[James Su, 2011-03-18 07:25:10]

Hi,
  It's the fourth CL of the new Views input method API. It depends on CL:
http://codereview.chromium.org/6711008/

Regards
James Su

[James Su, 2011-03-18 21:10:24]

This CL is ready for review.

[Evan Stade, 2011-03-18 21:15:41]

which part did you want me to look at? I know next to nothing about IMEs, so I
can do a best-effort review but I'm not sure how useful it would be.

[James Su, 2011-03-18 21:25:53]

On 2011/03/18 21:15:41, Evan Stade wrote:
> which part did you want me to look at? I know next to nothing about IMEs, so I
> can do a best-effort review but I'm not sure how useful it would be.

Can you help review the part in ui/base/gtk? But anyway, these are mostly old
code. I'm just wondering if changes to *.gyp* files are ok.

[Peng, 2011-03-21 18:18:14]

gtk_im_context_wrapper.[h,cc] LGTM.

And I am not sure if if it is good to put those code in ui/base/gtk.

And is it necessary to put ime_input.[h,cc] in ui/base/win? Seems it should not
be shared in your new design. and it should be a part of
views/ime/input_method_win.[ch], and chrome should use
views/ime/input_method_win.[ch] instead of using ime_input.[h,cc] directly,
right?


On 2011/03/18 07:25:10, James Su wrote:
> Hi,
>   It's the fourth CL of the new Views input method API. It depends on CL:
> http://codereview.chromium.org/6711008/
> 
> Regards
> James Su

[James Su, 2011-03-21 19:19:26]

On 2011/03/21 18:18:14, Peng wrote:
> gtk_im_context_wrapper.[h,cc] LGTM.
> 
> And I am not sure if if it is good to put those code in ui/base/gtk.
gtk_im_context_wrapper.* are only used by RenderWidgetHostViewGtk, so it's
better to stay in chrome/browser/renderer_host/

> 
> And is it necessary to put ime_input.[h,cc] in ui/base/win? Seems it should
not
> be shared in your new design. and it should be a part of
> views/ime/input_method_win.[ch], and chrome should use
> views/ime/input_method_win.[ch] instead of using ime_input.[h,cc] directly,
> right?
ime_input.* are used by both RenderWidgetHostViewWin and
views/ime/input_method_win.*. And unfortunately, we can't use input_method_win.*
in RenderWidgetHostViewWin.
I do hope RenderWidgetHostViewWin could be replaced by RenderWidgetHostViewViews
in the near future.

> 
> 
> On 2011/03/18 07:25:10, James Su wrote:
> > Hi,
> >   It's the fourth CL of the new Views input method API. It depends on CL:
> > http://codereview.chromium.org/6711008/
> > 
> > Regards
> > James Su

[Peng, 2011-03-21 19:36:11]

On 2011/03/21 19:19:26, James Su wrote:
> On 2011/03/21 18:18:14, Peng wrote:
> > gtk_im_context_wrapper.[h,cc] LGTM.
> > 
> > And I am not sure if if it is good to put those code in ui/base/gtk.
> gtk_im_context_wrapper.* are only used by RenderWidgetHostViewGtk, so it's
> better to stay in chrome/browser/renderer_host/

Sorry. I mean I am not sure if it is good to put gtk_im_context_util*.[h,cc] in
ui/base/gtk.

> 
> > 
> > And is it necessary to put ime_input.[h,cc] in ui/base/win? Seems it should
> not
> > be shared in your new design. and it should be a part of
> > views/ime/input_method_win.[ch], and chrome should use
> > views/ime/input_method_win.[ch] instead of using ime_input.[h,cc] directly,
> > right?
> ime_input.* are used by both RenderWidgetHostViewWin and
> views/ime/input_method_win.*. And unfortunately, we can't use
input_method_win.*
> in RenderWidgetHostViewWin.
> I do hope RenderWidgetHostViewWin could be replaced by
RenderWidgetHostViewViews
> in the near future.
> 
> > 
> > 
> > On 2011/03/18 07:25:10, James Su wrote:
> > > Hi,
> > >   It's the fourth CL of the new Views input method API. It depends on CL:
> > > http://codereview.chromium.org/6711008/
> > > 
> > > Regards
> > > James Su

[oshima, 2011-03-21 20:41:20]

Looks OK, but I'm probably less qualified to review this than others, so I'll
leave the final decision to other reviews.

[James Su, 2011-03-23 00:40:40]

Hi Ben,
  Can you help look at this CL? Mostly, it just moves code around. I want to
know if the new code locations are ok.

Regards
James Su

[sky, 2011-03-23 22:52:11]

LGTM