Issue 6709018: Simplify handing of activate; return activate errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6709018: Simplify handing of activate; return activate errors (Closed)

Created:
9 years, 9 months ago by Jason Glasgow

Modified:
9 years, 7 months ago

Reviewers:
Eric Shienbrood

CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Nathan Williams, Eric Shienbrood, rochberg, Paul Stewart, Elly Fong-Jones

Base URL:
ssh://git@gitrw.chromium.org:9222/flimflam.git@master

Visibility:
Public.

Description

Simplify activation by making its implementation be a simple DBUS call and a handler for the reply. By simplifying the handling of activate we can more easily handle errors that are returned by the call to activate, and we avoid holding a modem object around if cromo dies during activation (there will be no outstanding task). BUG=chromium-os:12913 TEST=Run through activation at Verizon twice, use fake-modem to test activation errors Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4080782

Patch Set 1 #

Patch Set 2 : Revert python changes. Get in a different CL #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -87 lines)			Patch
	M	plugins/modemmgr.c	View		11 chunks	+73 lines, -87 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

I will pull out the Python changes and submit separately.

9 years, 9 months ago (2011-03-18 03:27:49 UTC) #1

LGTM

Expand Messages | Collapse Messages