Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: printing/pdf_ps_metafile_cairo.cc

Issue 6709009: Stop overloading Init() in NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/pdf_ps_metafile_cairo.h ('k') | printing/pdf_ps_metafile_cairo_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/pdf_ps_metafile_cairo.cc
diff --git a/printing/pdf_ps_metafile_cairo.cc b/printing/pdf_ps_metafile_cairo.cc
index faab29f4730ba1e2ac737fe18b7cd27f004ae539..cfa89e444885f4fcf56e84f6ae73dacb16f5de01 100644
--- a/printing/pdf_ps_metafile_cairo.cc
+++ b/printing/pdf_ps_metafile_cairo.cc
@@ -113,7 +113,8 @@ bool PdfPsMetafile::Init() {
return true;
}
-bool PdfPsMetafile::Init(const void* src_buffer, uint32 src_buffer_size) {
+bool PdfPsMetafile::InitFromData(const void* src_buffer,
+ uint32 src_buffer_size) {
// We need to check at least these two members to ensure Init() has not been
// called before
DCHECK(!context_);
@@ -131,7 +132,7 @@ bool PdfPsMetafile::SetRawData(const void* src_buffer,
uint32 src_buffer_size) {
if (!context_) {
// If Init has not already been called, just call Init()
- return Init(src_buffer, src_buffer_size);
+ return InitFromData(src_buffer, src_buffer_size);
}
// If a context has already been created, remember this data in
// raw_override_data_
« no previous file with comments | « printing/pdf_ps_metafile_cairo.h ('k') | printing/pdf_ps_metafile_cairo_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698