Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 6708114: Revert 79691 - Move WebUIFactory to chrome/browser. (Closed)

Created:
9 years, 9 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 79691 - Move WebUIFactory to chrome/browser. This reduces dependencies from content/ to chrome/. WebUIFactory is the interface in content/ to ChromeWebUIFactory in chrome/ BUG=77092 TEST=none Review URL: http://codereview.chromium.org/6713082 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -714 lines) Patch
M chrome/browser/browser_url_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/favicon_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/browser/ui/webui/chrome_web_ui_factory.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 chunk +0 lines, -359 lines 0 comments Download
A + chrome/browser/ui/webui/generic_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/generic_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browsing_instance.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/content_browser_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
D content/browser/content_browser_client.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/site_instance.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 8 chunks +13 lines, -19 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
D content/browser/webui/empty_web_ui_factory.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/browser/webui/empty_web_ui_factory.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/webui/generic_handler.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/browser/webui/generic_handler.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M content/browser/webui/web_ui.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/webui/web_ui.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/webui/web_ui_factory.h View 1 chunk +42 lines, -31 lines 0 comments Download
M content/browser/webui/web_ui_factory.cc View 1 chunk +336 lines, -6 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Evan Stade
9 years, 9 months ago (2011-03-29 16:54:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698