Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 6708113: Allow PNG_EASY_ACCESS_SUPPORTED (Closed)

Created:
9 years, 9 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Nico, agl
CC:
chromium-reviews
Visibility:
Public.

Description

Allow PNG_EASY_ACCESS_SUPPORTED by not defining PNG_NO_EASY_ACCESS. This enables [wk_]png_get_image_width, [wk_]png_get_image_height, and [wk_]png_get_interlace_type, required for https://bugs.webkit.org/show_bug.cgi?id=54406. This is needed to allow WebKit to build with libpng 1.5, which no longer allows direct access to the underlying struct members without using the "easy access" accessors. BUG=webkit:54406 TEST=That patch can land without breaking Chromium Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/libpng/README.chromium View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/libpng/pngusr.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
thakis and agl, because you’re the last two guys to have made real changes in ...
9 years, 9 months ago (2011-03-29 16:16:43 UTC) #1
agl
LGTM
9 years, 9 months ago (2011-03-29 16:19:13 UTC) #2
Nico
LG
9 years, 8 months ago (2011-03-30 15:21:47 UTC) #3
Nico
9 years, 8 months ago (2011-03-30 15:35:56 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698