Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 6708093: Load devtools files from resources.pak rather than from disk take 2. (Closed)

Created:
9 years, 9 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Load devtools files from resources.pak rather than from disk take 2. This change merges devtools_resources.pak into resources.pak and puts the code to load files from disk behind a command line switch. If --debug-devtools is passed on the command line, we enable the code to load from disk (so the developer can make changes to the .js files without having to recompile or restart the browser). I also tried to make sure we no longer include the resources directory in release packages, but I probably missed something. This time, make sure to include the devtools_resources.pak in Chromium.app on OSX. BUG=35793 TBR=pfeldman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79038

Patch Set 1 #

Patch Set 2 : win deps #

Patch Set 3 : for landing #

Patch Set 4 : grd change to force rules to run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -19 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 8 chunks +12 lines, -8 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698