chrome/browser/renderer_host/browser_render_process_host.cc - Issue 6708059: Turn on client-side phishing detection for UMA users with SafeBrowsing enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 6708059: Turn on client-side phishing detection for UMA users with SafeBrowsing enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/browser_render_process_host.cc

diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc

index 187d840a0a2ad21cbd07f911732a404244d38bfa..c6997c2b3172f39ea339ade64b25df8e99350439 100644

--- a/chrome/browser/renderer_host/browser_render_process_host.cc

+++ b/chrome/browser/renderer_host/browser_render_process_host.cc

@@ -783,10 +783,10 @@ void BrowserRenderProcessHost::PropagateBrowserCommandLineToRenderer(

renderer_cmd->AppendSwitch(switches::kDisableDatabases);

}

- // Only enable client-side phishing detection in the renderer if it is enabled

+ // Disable client-side phishing detection in the renderer if it is disabled

// in the browser process.

- if (g_browser_process->safe_browsing_detection_service()) {

- renderer_cmd->AppendSwitch(switches::kEnableClientSidePhishingDetection);

+ if (!g_browser_process->safe_browsing_detection_service()) {

+ renderer_cmd->AppendSwitch(switches::kDisableClientSidePhishingDetection);

}