Issue 6708046: Revert 78812 - Unfork VectorPlatformCanvas.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6708046: Revert 78812 - Unfork VectorPlatformCanvas. (Closed)

Created:
9 years, 9 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 78812 - Unfork VectorPlatformCanvas. Unfork VectorPlatformCanvas by making NativeMetafile know how to create an appropriate VectorPlatformDevice. This will also be useful when we have multiple NativeMetafile implemenations (each requiring a different VectorPlatformDevices). BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78662 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=78663 Review URL: http://codereview.chromium.org/6665046 TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78815

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -90 lines)			Patch
M	chrome/renderer/print_web_view_helper_linux.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	3 chunks	+47 lines, -10 lines	0 comments	Download
M	printing/emf_win.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	printing/emf_win.cc	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	printing/native_metafile.h	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	printing/pdf_metafile_mac.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	printing/pdf_metafile_mac.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	skia/ext/vector_canvas.h	View	1 chunk	+21 lines, -4 lines	0 comments	Download
M	skia/ext/vector_canvas.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	skia/ext/vector_canvas_linux.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
A +	skia/ext/vector_canvas_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	skia/ext/vector_platform_device_linux.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/ext/vector_platform_device_linux.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	skia/ext/vector_platform_device_win.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	skia/ext/vector_platform_device_win.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	skia/skia.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages