NetLog: Removes private information from net-internals events tab

chrome/browser/resources/net_internals/main.js

Index: chrome/browser/resources/net_internals/main.js
===================================================================
--- chrome/browser/resources/net_internals/main.js	(revision 78565)
+++ chrome/browser/resources/net_internals/main.js	(working copy)
@@ -223,6 +223,11 @@
   // When viewing a log file, all tabs are hidden except the event view,
   // and all received events are ignored.
   this.isViewingLogFile_ = false;
+
+  // True when cookies and authentication information should be removed from
+  // displayed events.  When true, such information should be hidden from
+  // all pages.
+  this.doSecurityStripping_ = true;
 }
 
 /*
@@ -822,6 +827,27 @@
 };
 
 /**
+ * Sets the value of |doSecurityStripping_| and informs log observers
+ * of the change.
+ */
+BrowserBridge.prototype.setDoSecurityStripping =

[eroman, 2011/03/25 04:59:16]

nit: in this and other locations, I suggest dropping the "do" from the name, it
feels redundant.

In other words, just name this setSecurityStripping(), or
enableSecurityStripping()

[mmenke, 2011/03/28 14:55:36]

Done.  I renamed the bools to "enableSecurityStripping_" and removed the "do"
from function names (setSecurityStripping(), securityStripping()). 
"enableSecurityStripping()" sounds too ambiguous to me, as it could mean
actually enabling it, or getting whether it is enabled, given the variable name.

+    function(doSecurityStripping) {
+  this.doSecurityStripping_ = doSecurityStripping;

[eroman, 2011/03/25 04:59:16]

same naming comment applies to variable. Maybe just call this
enableSecurityStripping_

[mmenke, 2011/03/28 14:55:36]

Done.

+  for (var i = 0; i < this.logObservers_.length; ++i) {
+    if (this.logObservers_[i].onSecurityStrippingChanged)
+      this.logObservers_[i].onSecurityStrippingChanged();
+  }
+};
+
+/**
+ * Returns whether or not cookies and authentication information should be
+ * displayed for events that contain them.
+ */
+BrowserBridge.prototype.getDoSecurityStripping = function() {
+  return this.doSecurityStripping_;
+};
+
+/**
  * Informs log observers whether or not future events will be from a log file.
  * Hides all tabs except the events and data tabs when viewing a log file, shows
  * them all otherwise.