NetLog: Removes private information from net-internals events tab

chrome/browser/resources/net_internals/main.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Dictionary of constants (initialized by browser).
  */
 var LogEventType = null;
 var LogEventPhase = null;
 var ClientInfo = null;
@@ skipping 205 matching lines @@
   this.capturedEvents_ = [];
 
   // Next unique id to be assigned to a log entry without a source.
   // Needed to simplify deletion, identify associated GUI elements, etc.
   this.nextSourcelessEventId_ = -1;
 
   // True when viewing a log file rather than actively logged events.
   // When viewing a log file, all tabs are hidden except the event view,
   // and all received events are ignored.
   this.isViewingLogFile_ = false;
+
+  // True when cookies and authentication information should be removed from
+  // displayed events.  When true, such information should be hidden from
+  // all pages.
+  this.doSecurityStripping_ = true;
 }
 
 /*
  * Takes the current hash in form of "#tab&param1=value1&param2=value2&...".
  * Puts the parameters in an object, and passes the resulting object to
  * |categoryTabSwitcher|.  Uses tab and |anchorMap| to find a tab ID,
  * which it also passes to the tab switcher.
  *
  * Parameters and values are decoded with decodeURIComponent().
  */
@@ skipping 579 matching lines @@
  * Deletes all captured events.
  */
 BrowserBridge.prototype.deleteAllEvents = function() {
   this.capturedEvents_ = [];
   this.numPassivelyCapturedEvents_ = 0;
   for (var i = 0; i < this.logObservers_.length; ++i)
     this.logObservers_[i].onAllLogEntriesDeleted();
 };
 
 /**
+ * Sets the value of |doSecurityStripping_| and informs log observers
+ * of the change.
+ */
+BrowserBridge.prototype.setDoSecurityStripping =

[eroman, 2011/03/25 04:59:16]

nit: in this and other locations, I suggest dropping the "do" from the name, it
feels redundant.

In other words, just name this setSecurityStripping(), or
enableSecurityStripping()

[mmenke, 2011/03/28 14:55:36]

Done.  I renamed the bools to "enableSecurityStripping_" and removed the "do"
from function names (setSecurityStripping(), securityStripping()). 
"enableSecurityStripping()" sounds too ambiguous to me, as it could mean
actually enabling it, or getting whether it is enabled, given the variable name.

+    function(doSecurityStripping) {
+  this.doSecurityStripping_ = doSecurityStripping;

[eroman, 2011/03/25 04:59:16]

same naming comment applies to variable. Maybe just call this
enableSecurityStripping_

[mmenke, 2011/03/28 14:55:36]

Done.

+  for (var i = 0; i < this.logObservers_.length; ++i) {
+    if (this.logObservers_[i].onSecurityStrippingChanged)
+      this.logObservers_[i].onSecurityStrippingChanged();
+  }
+};
+
+/**
+ * Returns whether or not cookies and authentication information should be
+ * displayed for events that contain them.
+ */
+BrowserBridge.prototype.getDoSecurityStripping = function() {
+  return this.doSecurityStripping_;
+};
+
+/**
  * Informs log observers whether or not future events will be from a log file.
  * Hides all tabs except the events and data tabs when viewing a log file, shows
  * them all otherwise.
  */
 BrowserBridge.prototype.setIsViewingLogFile_ = function(isViewingLogFile) {
   this.isViewingLogFile_ = isViewingLogFile;
   var tabIds = this.categoryTabSwitcher_.getAllTabIds();
 
   for (var i = 0; i < this.logObservers_.length; ++i)
     this.logObservers_[i].onSetIsViewingLogFile(isViewingLogFile);
@@ skipping 149 matching lines @@
   return true;
 };
 
 UpdateAllObserver.prototype.onDataReceived_ = function(helper, name, data) {
   helper.removeObserver(this);
   --this.observingCount_;
   this.updatedData_[name] = data;
   if (this.observingCount_ == 0)
     this.callback_(this.updatedData_);
 };