NetLog: Removes private information from net-internals events tab

NetLog:  Removes private information from net-internals events
tab when "Exclude private information" is checked on the Dump
data tab, to prevent end users accidentally revealing their
passwords or other private information.

BUG=76689
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79594

[mmenke, 2011-03-18 18:30:11]

There was a case or two of someone pasting data from the events tab with
password information, rather than using the dump data tab.  Hence, this CL.

Pretty low priority review, as it's unlikely to run into conflicts with other
code changes.  If you're still working on that release blocker, feel free to put
it off as long as you want, though it's not exactly a big CL.

[eroman, 2011-03-25 04:59:16]

LGTM.

(sorry for delay, I was out sick last week).

http://codereview.chromium.org/6708030/diff/6001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/main.js (right):

http://codereview.chromium.org/6708030/diff/6001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/main.js:833:
BrowserBridge.prototype.setDoSecurityStripping =
nit: in this and other locations, I suggest dropping the "do" from the name, it
feels redundant.

In other words, just name this setSecurityStripping(), or
enableSecurityStripping()

http://codereview.chromium.org/6708030/diff/6001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/main.js:835: this.doSecurityStripping_ =
doSecurityStripping;
same naming comment applies to variable. Maybe just call this
enableSecurityStripping_

[mmenke, 2011-03-28 14:55:36]

Thanks.  Delay wasn't a problem at all.

http://codereview.chromium.org/6708030/diff/6001/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/main.js (right):

http://codereview.chromium.org/6708030/diff/6001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/main.js:833:
BrowserBridge.prototype.setDoSecurityStripping =
On 2011/03/25 04:59:16, eroman wrote:
> nit: in this and other locations, I suggest dropping the "do" from the name,
it
> feels redundant.
> 
> In other words, just name this setSecurityStripping(), or
> enableSecurityStripping()

Done.  I renamed the bools to "enableSecurityStripping_" and removed the "do"
from function names (setSecurityStripping(), securityStripping()). 
"enableSecurityStripping()" sounds too ambiguous to me, as it could mean
actually enabling it, or getting whether it is enabled, given the variable name.

http://codereview.chromium.org/6708030/diff/6001/chrome/browser/resources/net...
chrome/browser/resources/net_internals/main.js:835: this.doSecurityStripping_ =
doSecurityStripping;
On 2011/03/25 04:59:16, eroman wrote:
> same naming comment applies to variable. Maybe just call this
> enableSecurityStripping_

Done.