Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 6708026: Merge 76889 - 2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com> (Closed)

Created:
9 years, 9 months ago by kerz_chromium
Modified:
9 years, 7 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 76889 - 2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com>; Reviewed by Ojan Vafai. This addresses a regression introduced by r75784, as described in: https://bugs.webkit.org/show_bug.cgi?id=53176 The problem is that originalEndContainer and originalEndOffset was meant to capture the end of the document, but was being assigned after a call to searchRange->setStart() (when scoping is restarted), which can result in the Range being collapsed to start (thereby assigning the wrong value to the Container/Offset pair). This code is never triggered by layout tests, but I'm adding a regressiono test on the Chromium side for this. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches): TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +20 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
9 years, 9 months ago (2011-03-18 17:07:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698