Issue 6708025: ARM: Add optimization for constant RHS in DoMulI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6708025: ARM: Add optimization for constant RHS in DoMulI (Closed)

Created:
9 years, 9 months ago by m.m.capewell

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add optimization for constant RHS in DoMulI. Patch by ARM Ltd.

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -29 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+121 lines, -25 lines	1 comment	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/utils.h	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM http://codereview.chromium.org/6708025/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6708025/diff/1/src/arm/lithium-codegen-arm.cc#newcode1030 src/arm/lithium-codegen-arm.cc:1030: Consider removing the blank lines between the cases ...

9 years, 9 months ago (2011-03-21 13:37:37 UTC) #3

I will do the changes and land the patch.

Expand Messages | Collapse Messages