Issue 6708014: Fix compilation on Windows post-7252

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6708014: Fix compilation on Windows post-7252 (Closed)

Created:
9 years, 9 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Martin Maly

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix compilation on Windows post-7252 Committed: http://code.google.com/p/v8/source/detail?r=7253

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	src/code-stubs.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	src/heap.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

TBR=kmillikin, mmaly The patch by Martin, I'm landing it after building/testing on Win.

9 years, 9 months ago (2011-03-17 21:12:04 UTC) #1

Martin Maly

9 years, 9 months ago (2011-03-17 21:15:37 UTC) #2

LGTM.

Unfortunately the change Kevin helped me scheme up to make gcc happy didn't take
for msvc. I will work with Kevin to find the right fix that makes all compilers
happy if this is not ideal.

Thanks, Dmitry!
Martin

Expand Messages | Collapse Messages