Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 6708013: Add separate ContentClient interfaces for gpu/plugin/renderer processes. Since we don't have a n... (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, apatrick_chromium, brettw-cc_chromium.org
Visibility:
Public.

Description

Add separate ContentClient interfaces for gpu/plugin/renderer processes. Since we don't have a need for a chrome/gpu or chrome/plugin directory, their chrome implementations are in chrome/common. Use the renderer one for getting the sad plugin image. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78617

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -80 lines) Patch
M chrome/app/chrome_main.cc View 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A chrome/common/chrome_content_gpu_client.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/common/chrome_content_gpu_client.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/common/chrome_content_plugin_client.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/common/chrome_content_plugin_client.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/renderer/chrome_content_renderer_client.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/browser_with_test_window_test.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/content_browser_client.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/content_client.h View 2 chunks +21 lines, -19 lines 0 comments Download
M content/common/content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A content/gpu/content_gpu_client.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M content/gpu/gpu_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A content/plugin/content_plugin_client.h View 1 chunk +23 lines, -0 lines 0 comments Download
M content/plugin/plugin_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A content/renderer/content_renderer_client.h View 1 chunk +23 lines, -0 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 9 months ago (2011-03-17 21:11:31 UTC) #1
Avi (use Gerrit)
LG seems like the content layer is learning more and more about the layers on ...
9 years, 9 months ago (2011-03-17 22:03:43 UTC) #2
jam
9 years, 9 months ago (2011-03-17 22:06:02 UTC) #3
On Thu, Mar 17, 2011 at 3:03 PM, <avi@chromium.org> wrote:

> LG
>
> seems like the content layer is learning more and more about the layers on
> top
> of it.


the goal is for this not to happen :)  the apis added to contentclient are
stuff that the embedder can't figure out on its own.  i.e. when a crash
happens, it's too late to get the GpuInfo.  embedder needs to be called ot
know that a plugin process started, or RenderView is created etc.  they can
then add their own hooks onto these objects.


>
> http://codereview.chromium.org/6708013/
>

Powered by Google App Engine
This is Rietveld 408576698