Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 67068: Merge 13028 - Bug 2220 lists two cases where the inactive highlighting doesn'... (Closed)

Created:
11 years, 8 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Merge 13028 - Bug 2220 lists two cases where the inactive highlighting doesn't reappear on FindNext. This is a simple fix for one of those cases (user presses Refresh after Find). BUG=2220 TEST=Open google.com, press Find, press e, press Refresh, press F3 (or FindNext button in UI). Then make sure the inactive matches are highlighted (not just the active match). Review URL: http://codereview.chromium.org/56193 TBR=finnur@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/browser/find_bar_controller.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.h View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 8 months ago (2009-04-11 19:53:44 UTC) #1
Finnur
11 years, 8 months ago (2009-04-11 22:28:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698