Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/platform-tls-mac.h

Issue 6706018: Fix fast TLS support on Mac. (Closed)
Patch Set: Addressing review comment Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/platform-macos.cc ('K') | « src/platform-macos.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 30
31 #include "globals.h" 31 #include "globals.h"
32 32
33 namespace v8 { 33 namespace v8 {
34 namespace internal { 34 namespace internal {
35 35
36 #if defined(V8_HOST_ARCH_IA32) || defined(V8_HOST_ARCH_X64) 36 #if defined(V8_HOST_ARCH_IA32) || defined(V8_HOST_ARCH_X64)
37 37
38 #define V8_FAST_TLS_SUPPORTED 1 38 #define V8_FAST_TLS_SUPPORTED 1
39 39
40 extern intptr_t kMacTlsBaseOffset;
41
40 INLINE(intptr_t InternalGetExistingThreadLocal(intptr_t index)); 42 INLINE(intptr_t InternalGetExistingThreadLocal(intptr_t index));
41 43
42 inline intptr_t InternalGetExistingThreadLocal(intptr_t index) { 44 inline intptr_t InternalGetExistingThreadLocal(intptr_t index) {
43 // The constants below are taken from pthreads.s from the XNU kernel
44 // sources archive at www.opensource.apple.com.
45 intptr_t result; 45 intptr_t result;
46 #if defined(V8_HOST_ARCH_IA32) 46 #if defined(V8_HOST_ARCH_IA32)
47 asm("movl %%gs:0x48(,%1,4), %0;" 47 asm("movl %%gs:(%1,%2,4), %0;"
48 :"=r"(result) // Output must be a writable register. 48 :"=r"(result) // Output must be a writable register.
49 :"0"(index)); // Input is the same as output. 49 :"r"(kMacTlsBaseOffset), "r"(index));
Mark Mentovai 2011/04/01 16:37:16 You might do better by letting the output share a
Vitaly Repeshko 2011/04/01 16:47:55 GCC docs say the compiler is free to reuse a regis
50 #else 50 #else
51 asm("movq %%gs:0x60(,%1,8), %0;" 51 asm("movq %%gs:(%1,%2,8), %0;"
52 :"=r"(result) 52 :"=r"(result)
53 :"0"(index)); 53 :"r"(kMacTlsBaseOffset), "r"(index));
54 #endif 54 #endif
55 return result; 55 return result;
56 } 56 }
57 57
58 #endif 58 #endif
59 59
60 } } // namespace v8::internal 60 } } // namespace v8::internal
61 61
62 #endif // V8_PLATFORM_TLS_MAC_H_ 62 #endif // V8_PLATFORM_TLS_MAC_H_
OLDNEW
« src/platform-macos.cc ('K') | « src/platform-macos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698