Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 6706016: Do not create a SharedFunctionInfo for closures on each recompilation. (Closed)

Created:
9 years, 8 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not create a SharedFunctionInfo for closures on each recompilation. Unoptimized code should already keep a reference to the SharedFunctionInfo, let's use it instead of allocating a new object and prohibiting SharedFunctionInfo specific optimizations. Committed: http://code.google.com/p/v8/source/detail?r=7467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/hydrogen.cc View 1 chunk +25 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Guys, may you have a look? Search algorithm is quite simple. If it'll prove to ...
9 years, 8 months ago (2011-04-01 09:37:41 UTC) #1
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-04-01 10:15:06 UTC) #2
LGTM.

We could also consider the same trick when we are recompiling the unoptimized
code to attach deoptimization info.

Maybe we could do something simple like inspect the CompilationInfo's
SharedFunctionInfo to see if it has code that's not the lazy compilation stub.

Powered by Google App Engine
This is Rietveld 408576698