Wrap raw_input() around a try/except to reduce the number of false-positive in breakpad

git_cl.py

 #!/usr/bin/python
 # git-cl -- a git-command for integrating reviews on Rietveld
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 import errno
 import logging
 import optparse
 import os
 import re
 import subprocess
@@ skipping 24 matching lines @@
 import presubmit_support
 import scm
 import watchlists
 
 
 
 DEFAULT_SERVER = 'http://codereview.appspot.com'
 POSTUPSTREAM_HOOK_PATTERN = '.git/hooks/post-cl-%s'
 DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
 
+
 def DieWithError(message):
   print >> sys.stderr, message
   sys.exit(1)
 
 
 def Popen(cmd, **kwargs):
   """Wrapper for subprocess.Popen() that logs and watch for cygwin issues"""
   logging.info('Popen: ' + ' '.join(cmd))
   try:
     return subprocess.Popen(cmd, **kwargs)
@@ skipping 35 matching lines @@
   return proc.returncode, output
 
 
 def usage(more):
   def hook(fn):
     fn.usage_more = more
     return fn
   return hook
 
 
+def ask_for_data(prompt):
+  try:
+    return raw_input(prompt)
+  except KeyboardInterrupt:
+    # Hide the exception.
+    sys.exit(1)
+
+
 def FixUrl(server):
   """Fix a server url to defaults protocol to http:// if none is specified."""
   if not server:
     return server
   if not re.match(r'[a-z]+\://.*', server):
     return 'http://' + server
   return server
 
 
 def MatchSvnGlob(url, base_url, glob_spec, allow_wildcards):
@@ skipping 408 matching lines @@
   def _RietveldServer(self):
     """Returns the git setting that stores this change's rietveld server."""
     return 'branch.%s.rietveldserver' % self.GetBranch()
 
 
 def GetCodereviewSettingsInteractively():
   """Prompt the user for settings."""
   server = settings.GetDefaultServerUrl(error_ok=True)
   prompt = 'Rietveld server (host[:port])'
   prompt += ' [%s]' % (server or DEFAULT_SERVER)
-  newserver = raw_input(prompt + ': ')
+  newserver = ask_for_data(prompt + ':')
   if not server and not newserver:
     newserver = DEFAULT_SERVER
   if newserver and newserver != server:
     RunGit(['config', 'rietveld.server', newserver])
 
   def SetProperty(initial, caption, name):
     prompt = caption
     if initial:
       prompt += ' ("x" to clear) [%s]' % initial
-    new_val = raw_input(prompt + ': ')
+    new_val = ask_for_data(prompt + ':')
     if new_val == 'x':
       RunGit(['config', '--unset-all', 'rietveld.' + name], error_ok=True)
     elif new_val and new_val != initial:
       RunGit(['config', 'rietveld.' + name, new_val])
 
   SetProperty(settings.GetCCList(), 'CC list', 'cc')
   SetProperty(settings.GetTreeStatusUrl(error_ok=True), 'Tree status URL',
               'tree-status-url')
   SetProperty(settings.GetViewVCUrl(), 'ViewVC URL', 'viewvc-url')
 
@@ skipping 556 matching lines @@
   if options.contributor:
     if not re.match('^.*\s<\S+@\S+>$', options.contributor):
       print "Please provide contibutor as 'First Last <email@example.com>'"
       return 1
     description += "\nPatch from %s." % options.contributor
   print 'Description:', repr(description)
 
   branches = [base_branch, cl.GetBranchRef()]
   if not options.force:
     subprocess.call(['git', 'diff', '--stat'] + branches)
-    raw_input("About to commit; enter to confirm.")
+    ask_for_data('About to commit; enter to confirm.')
 
   # We want to squash all this branch's commits into one commit with the
   # proper description.
   # We do this by doing a "reset --soft" to the base branch (which keeps
   # the working copy the same), then dcommitting that.
   MERGE_BRANCH = 'git-cl-commit'
   # Delete the merge branch if it already exists.
   if RunGitWithCode(['show-ref', '--quiet', '--verify',
                      'refs/heads/' + MERGE_BRANCH])[0] == 0:
     RunGit(['branch', '-D', MERGE_BRANCH])
@@ skipping 64 matching lines @@
   """commit the current changelist via git-svn"""
   if not settings.GetIsGitSvn():
     message = """This doesn't appear to be an SVN repository.
 If your project has a git mirror with an upstream SVN master, you probably need
 to run 'git svn init', see your project's git mirror documentation.
 If your project has a true writeable upstream repository, you probably want
 to run 'git cl push' instead.
 Choose wisely, if you get this wrong, your commit might appear to succeed but
 will instead be silently ignored."""
     print(message)
-    raw_input('[Press enter to dcommit or ctrl-C to quit]')
+    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
   return SendUpstream(parser, args, 'dcommit')
 
 
 @usage('[upstream branch to apply against]')
 def CMDpush(parser, args):
   """commit the current changelist via git"""
   if settings.GetIsGitSvn():
     print('This appears to be an SVN repository.')
     print('Are you sure you didn\'t mean \'git cl dcommit\'?')
-    raw_input('[Press enter to push or ctrl-C to quit]')
+    ask_for_data('[Press enter to push or ctrl-C to quit]')
   return SendUpstream(parser, args, 'push')
 
 
 @usage('<patch url or issue id>')
 def CMDpatch(parser, args):
   """patch in a code review"""
   parser.add_option('-b', dest='newbranch',
                     help='create a new branch off trunk for the patch')
   parser.add_option('-f', action='store_true', dest='force',
                     help='with -b, clobber any existing branch')
@@ skipping 185 matching lines @@
             ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))