Disable gcc 4.4 warnings about hash_map and hash_set being

Disable gcc 4.4 warnings about hash_map and hash_set being
deprecated.

backward_warning.h in gcc 4.4.0 wraps the warning around an ifdef __DEPRECATED.

[Mark Mentovai, 2009-04-11 01:17:27]

http://codereview.chromium.org/67056/diff/1/2
File base/hash_tables.h (right):

http://codereview.chromium.org/67056/diff/1/2#newcode35
Line 35: #define __DEPRECATED CHROME_OLD__DEPRECATED
This will result in __DEPRECATED being defined even if it wasn't defined
initially.  I don't think that's what you intend.

How about this:

#ifdef __D
#define C_O__D __D
#undef __D
#endif

#include <...>

#ifdef C_O__D
#define __D C_O__D
#undef C_O__D
#endif

[Craig Schlenter, 2009-04-11 14:43:15]

This looks good modulo Mark's comments. Thanks for looking into this! I thought
of one other way to do this - create a custom backward_warning.h that shows up
on the include search path before the gcc one. Both hash_map and hash_set seem
to do #include "backward_warning.h".

I'll close my "no-deprecated" CL now btw. since I think this is way better.

Thank you!

[tony, 2009-04-13 16:50:28]

Updated.  Take another look?

On 2009/04/11 01:17:27, Mark Mentovai wrote:
> http://codereview.chromium.org/67056/diff/1/2
> File base/hash_tables.h (right):
> 
> http://codereview.chromium.org/67056/diff/1/2#newcode35
> Line 35: #define __DEPRECATED CHROME_OLD__DEPRECATED
> This will result in __DEPRECATED being defined even if it wasn't defined
> initially.  I don't think that's what you intend.
> 
> How about this:
> 
> #ifdef __D
> #define C_O__D __D
> #undef __D
> #endif
> 
> #include <...>
> 
> #ifdef C_O__D
> #define __D C_O__D
> #undef C_O__D
> #endif

[Mark Mentovai, 2009-04-13 16:52:08]

Looks good now.

[M-A Ruel, 2009-04-13 16:55:32]

lgtm