Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: build/common.gypi

Issue 6705030: Standardize grit invokes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/app.gyp ('k') | build/grit_action.gypi » ('j') | build/grit_action.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 79444)
+++ build/common.gypi (working copy)
@@ -488,13 +488,15 @@
'use_gconf%': 1,
}],
- # Setup -D flags passed into grit.
+ # Setup -D and -E flags passed into grit.
Mark Mentovai 2011/03/25 20:16:53 Set up as a verb is two words.
['branding=="Chrome"', {
# TODO(mmoss) The .grd files look for _google_chrome, but for
# consistency they should look for google_chrome_build like C++.
- 'grit_defines': ['-D', '_google_chrome'],
+ 'grit_defines': ['-D', '_google_chrome',
+ '-E', 'CHROMIUM_BUILD=google_chrome'],
}, {
- 'grit_defines': ['-D', '_chromium'],
+ 'grit_defines': ['-D', '_chromium',
+ '-E', 'CHROMIUM_BUILD=chromium'],
}],
['chromeos==1', {
'grit_defines': ['-D', 'chromeos'],
@@ -1523,7 +1525,7 @@
'psapi.lib',
'dbghelp.lib',
],
- 'conditions': [
+ 'conditions': [
['msvs_express', {
# Explicitly required when using the ATL with express
'AdditionalDependencies': [
« no previous file with comments | « app/app.gyp ('k') | build/grit_action.gypi » ('j') | build/grit_action.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698