Standardize grit invokes

build/grit_action.gypi

+# Copyright (c) 2011 The Chromium Authors. All rights reserved.

[tony, 2011/03/25 18:07:04]

Should these files be in tools/grit/ near grit_info.py?  This kind of feels like
a vsprops file, which we used to keep near the code it applied too.

[TVL, 2011/03/25 18:15:53]

That was my first thought also, but they actually depend on the flags in
common.gypi, so it seemed like it might be a little better to hang them here.

Mark - Any thoughts?

[Mark Mentovai, 2011/03/25 18:22:07]

TVL wrote:
I’m fine with either location. I can see arguments for placing it in both spots.
I don’t have a preference between the two.

[tony, 2011/03/25 18:45:34]

My main concern was src/build/ getting too crowded, but this is OK for now.  We
can move the files later if we want.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# This file is meant to be included into an action to invoke grit in a
+# consistent manner. To use this the following variables need to be
+# defined:
+#   grit_grd_file: string: grd file path
+#   grit_out_dir: string: the output directory path
+#

[Mark Mentovai, 2011/03/25 18:22:07]

Remove this line.

[TVL, 2011/03/25 18:33:30]

Done.

+
+# It would be really nice to do this with a rule instead of actions, but
+# the need to come up with inputs/outputs (via grit_info) on a per file
+# basis causes the problem.  GYP Rules could be extended to do this, but

[Mark Mentovai, 2011/03/25 18:22:07]

“causes the problem”—which problem, you haven’t introduced a problem yet. Causes
a problem?

[Mark Mentovai, 2011/03/25 18:22:07]

Rules use a lowercase R.

[TVL, 2011/03/25 18:33:30]

Done.

+# then every generator would have to be able to do it, because that is when

[Mark Mentovai, 2011/03/25 18:22:07]

but then every generator would need to be updated to handle this.

[TVL, 2011/03/25 18:33:30]

Done.

+# the rules are expanded/applied.
+
+{
+  'variables': {
+    'grit_info_cmd': ['python', '<(DEPTH)/tools/grit/grit_info.py',
+                      '<@(grit_defines)'],
+    'grit_cmd': ['python', '<(DEPTH)/tools/grit/grit.py'],
+  },
+  'inputs': [
+    '<!@(<(grit_info_cmd) --inputs <(grit_grd_file))',

[Mark Mentovai, 2011/03/25 17:48:55]

Does this list grit.py itself (and any in-tree Python libraries) too?

[tony, 2011/03/25 18:07:04]

Yes, it should.

+  ],
+  'outputs': [
+    '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)\' <(grit_grd_file))',
+  ],
+  'action': ['<@(grit_cmd)',
+             '-i', '<(grit_grd_file)', 'build',
+             '-o', '<(grit_out_dir)',
+             '<@(grit_defines)' ],
+  'message': 'Generating resources from <(grit_grd_file)',
+}
+
+# Local Variables:
+# tab-width:2
+# indent-tabs-mode:nil
+# End:
+# vim: set expandtab tabstop=2 shiftwidth=2: