Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 6701003: X64: Port optimization of LMulI to x64. (Closed)

Created:
9 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

X64: Port optimization of LMulI to x64. Committed: http://code.google.com/p/v8/source/detail?r=7248

Patch Set 1 #

Patch Set 2 : Reuse can_overflow variable. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +42 lines, -2 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 9 months ago (2011-03-17 12:30:41 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/6701003/diff/2001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6701003/diff/2001/src/x64/lithium-codegen-x64.cc#newcode873 src/x64/lithium-codegen-x64.cc:873: } else if (right_value == 0) { If ...
9 years, 9 months ago (2011-03-17 12:55:06 UTC) #2
Lasse Reichstein
9 years, 9 months ago (2011-03-17 18:11:54 UTC) #3
http://codereview.chromium.org/6701003/diff/2001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6701003/diff/2001/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:873: } else if (right_value == 0) {
Yes, I noticed too that we bail out even if we don't know if the left-hand side
is negative.
I decided to keep it for now, under the assumption that if you are multiplying
by a constant zero, you are either doing something incredibly stupid or
something incredibly clever, but I won't try too hard to save a few bytes.
I'll fix it so we don't deoptimize on multiplying a positive value by constant
zero in another CL.

Powered by Google App Engine
This is Rietveld 408576698