Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/history/thumbnail_database_unittest.cc

Issue 6698031: fav icon -> favicon. Pass 7: FavIconID -> FaviconID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/thumbnail_database.cc ('k') | chrome/browser/history/url_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/thumbnail_database_unittest.cc
diff --git a/chrome/browser/history/thumbnail_database_unittest.cc b/chrome/browser/history/thumbnail_database_unittest.cc
index ecce8d2493472b8673b8594571cb28c47a78a95f..25aa26811ba5b30ca09e9eea7956a2a822d1fb3f 100644
--- a/chrome/browser/history/thumbnail_database_unittest.cc
+++ b/chrome/browser/history/thumbnail_database_unittest.cc
@@ -119,7 +119,7 @@ TEST_F(ThumbnailDatabaseTest, GetFaviconAfterMigrationToTopSites) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, FAV_ICON);
+ FaviconID id = db.AddFavIcon(url, FAV_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
EXPECT_TRUE(db.RenameAndDropThumbnails(file_name_, new_file_name_));
@@ -145,7 +145,7 @@ TEST_F(ThumbnailDatabaseTest, AddIconMapping) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, TOUCH_ICON);
+ FaviconID id = db.AddFavIcon(url, TOUCH_ICON);
EXPECT_NE(0, id);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
@@ -167,7 +167,7 @@ TEST_F(ThumbnailDatabaseTest, UpdateIconMapping) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, TOUCH_ICON);
+ FaviconID id = db.AddFavIcon(url, TOUCH_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
@@ -179,7 +179,7 @@ TEST_F(ThumbnailDatabaseTest, UpdateIconMapping) {
EXPECT_EQ(id, icon_mapping.front().icon_id);
GURL url1("http://www.google.com/");
- FavIconID new_id = db.AddFavIcon(url1, TOUCH_ICON);
+ FaviconID new_id = db.AddFavIcon(url1, TOUCH_ICON);
EXPECT_TRUE(db.UpdateIconMapping(icon_mapping.front().mapping_id, new_id));
icon_mapping.clear();
@@ -199,12 +199,12 @@ TEST_F(ThumbnailDatabaseTest, DeleteIconMappings) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, TOUCH_ICON);
+ FaviconID id = db.AddFavIcon(url, TOUCH_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
EXPECT_TRUE(0 < db.AddIconMapping(url, id));
- FavIconID id2 = db.AddFavIcon(url, FAV_ICON);
+ FaviconID id2 = db.AddFavIcon(url, FAV_ICON);
db.SetFavicon(id2, favicon, time);
EXPECT_TRUE(0 < db.AddIconMapping(url, id2));
ASSERT_NE(id, id2);
@@ -231,12 +231,12 @@ TEST_F(ThumbnailDatabaseTest, GetIconMappingsForPageURL) {
GURL url("http://google.com");
- FavIconID id1 = db.AddFavIcon(url, TOUCH_ICON);
+ FaviconID id1 = db.AddFavIcon(url, TOUCH_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id1, favicon, time);
EXPECT_TRUE(0 < db.AddIconMapping(url, id1));
- FavIconID id2 = db.AddFavIcon(url, FAV_ICON);
+ FaviconID id2 = db.AddFavIcon(url, FAV_ICON);
EXPECT_NE(id1, id2);
db.SetFavicon(id2, favicon, time);
EXPECT_TRUE(0 < db.AddIconMapping(url, id2));
@@ -275,7 +275,7 @@ TEST_F(ThumbnailDatabaseTest, UpgradeToVersion4) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, TOUCH_ICON);
+ FaviconID id = db.AddFavIcon(url, TOUCH_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
@@ -299,7 +299,7 @@ TEST_F(ThumbnailDatabaseTest, TemporayIconMapping) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, FAV_ICON);
+ FaviconID id = db.AddFavIcon(url, FAV_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
@@ -321,7 +321,7 @@ TEST_F(ThumbnailDatabaseTest, GetIconMappingsForPageURLForReturnOrder) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
GURL url("http://google.com");
- FavIconID id = db.AddFavIcon(url, FAV_ICON);
+ FaviconID id = db.AddFavIcon(url, FAV_ICON);
base::Time time = base::Time::Now();
db.SetFavicon(id, favicon, time);
@@ -337,7 +337,7 @@ TEST_F(ThumbnailDatabaseTest, GetIconMappingsForPageURLForReturnOrder) {
std::vector<unsigned char> data2(blob2, blob2 + sizeof(blob2));
scoped_refptr<RefCountedBytes> favicon2(new RefCountedBytes(data));
- FavIconID id2 = db.AddFavIcon(url, TOUCH_ICON);
+ FaviconID id2 = db.AddFavIcon(url, TOUCH_ICON);
db.SetFavicon(id2, favicon2, time);
EXPECT_NE(0, db.AddIconMapping(url, id2));
@@ -351,7 +351,7 @@ TEST_F(ThumbnailDatabaseTest, GetIconMappingsForPageURLForReturnOrder) {
// Add a touch precomposed icon
scoped_refptr<RefCountedBytes> favicon3(new RefCountedBytes(data2));
- FavIconID id3 = db.AddFavIcon(url, TOUCH_PRECOMPOSED_ICON);
+ FaviconID id3 = db.AddFavIcon(url, TOUCH_PRECOMPOSED_ICON);
db.SetFavicon(id3, favicon3, time);
EXPECT_NE(0, db.AddIconMapping(url, id3));
@@ -372,19 +372,19 @@ TEST_F(ThumbnailDatabaseTest, HasMappingFor) {
scoped_refptr<RefCountedBytes> favicon(new RefCountedBytes(data));
// Add a favicon which will have icon_mappings
- FavIconID id1 = db.AddFavIcon(GURL("http://google.com"), FAV_ICON);
+ FaviconID id1 = db.AddFavIcon(GURL("http://google.com"), FAV_ICON);
EXPECT_NE(id1, 0);
base::Time time = base::Time::Now();
db.SetFavicon(id1, favicon, time);
// Add another type of favicon
- FavIconID id2 = db.AddFavIcon(GURL("http://www.google.com/icon"), TOUCH_ICON);
+ FaviconID id2 = db.AddFavIcon(GURL("http://www.google.com/icon"), TOUCH_ICON);
EXPECT_NE(id2, 0);
time = base::Time::Now();
db.SetFavicon(id2, favicon, time);
// Add 3rd favicon
- FavIconID id3 = db.AddFavIcon(GURL("http://www.google.com/icon"), TOUCH_ICON);
+ FaviconID id3 = db.AddFavIcon(GURL("http://www.google.com/icon"), TOUCH_ICON);
EXPECT_NE(id3, 0);
time = base::Time::Now();
db.SetFavicon(id3, favicon, time);
« no previous file with comments | « chrome/browser/history/thumbnail_database.cc ('k') | chrome/browser/history/url_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698