Issue 6698029: Add a V8 benchmark suite run to test.py to catch failures on the buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6698029: Add a V8 benchmark suite run to test.py to catch failures on the buildbot. (Closed)

Created:
9 years, 9 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add a V8 benchmark suite run to test.py to catch failures on the buildbot. Committed: http://code.google.com/p/v8/source/detail?r=7198

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -2 lines)			Patch
	A	test/benchmarks/testcfg.py	View		1 chunk	+101 lines, -0 lines	2 comments	Download
	M	tools/test.py	View		3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM, I assume that the reason for not running with --debug-code --verify-heap flags are due ...

9 years, 9 months ago (2011-03-16 08:51:57 UTC) #2

Mads Ager (chromium)

9 years, 9 months ago (2011-03-16 09:44:33 UTC) #3

Thanks Rico.

Yes, the reason to run without verification flags in debug mode is that it takes
far too long for the buildbot.

http://codereview.chromium.org/6698029/diff/1/test/benchmarks/testcfg.py
File test/benchmarks/testcfg.py (right):

http://codereview.chromium.org/6698029/diff/1/test/benchmarks/testcfg.py#newc...
test/benchmarks/testcfg.py:57: if not IsNumber(line[colon_index+1:].strip()):
On 2011/03/16 08:51:57, Rico wrote:
> line[colon_index+1:].strip().isdigit() ?

I did that initially. The issue is that when running slowly in debug mode we
might get scores such as 65.6

Expand Messages | Collapse Messages