Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 6698015: Implement strict mode arguments caller/callee. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Kevin's feedback. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 735 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 ArgumentsAllocationMode mode = ArgumentsMode(); 746 ArgumentsAllocationMode mode = ArgumentsMode();
747 ASSERT(mode != NO_ARGUMENTS_ALLOCATION); 747 ASSERT(mode != NO_ARGUMENTS_ALLOCATION);
748 748
749 Comment cmnt(masm_, "[ store arguments object"); 749 Comment cmnt(masm_, "[ store arguments object");
750 if (mode == LAZY_ARGUMENTS_ALLOCATION && initial) { 750 if (mode == LAZY_ARGUMENTS_ALLOCATION && initial) {
751 // When using lazy arguments allocation, we store the arguments marker value 751 // When using lazy arguments allocation, we store the arguments marker value
752 // as a sentinel indicating that the arguments object hasn't been 752 // as a sentinel indicating that the arguments object hasn't been
753 // allocated yet. 753 // allocated yet.
754 frame_->Push(Factory::arguments_marker()); 754 frame_->Push(Factory::arguments_marker());
755 } else { 755 } else {
756 ArgumentsAccessStub stub(ArgumentsAccessStub::NEW_OBJECT); 756 ArgumentsAccessStub stub(is_strict_mode()
757 ? ArgumentsAccessStub::NEW_STRICT
758 : ArgumentsAccessStub::NEW_NON_STRICT);
757 frame_->PushFunction(); 759 frame_->PushFunction();
758 frame_->PushReceiverSlotAddress(); 760 frame_->PushReceiverSlotAddress();
759 frame_->Push(Smi::FromInt(scope()->num_parameters())); 761 frame_->Push(Smi::FromInt(scope()->num_parameters()));
760 Result result = frame_->CallStub(&stub, 3); 762 Result result = frame_->CallStub(&stub, 3);
761 frame_->Push(&result); 763 frame_->Push(&result);
762 } 764 }
763 765
764 Variable* arguments = scope()->arguments(); 766 Variable* arguments = scope()->arguments();
765 Variable* shadow = scope()->arguments_shadow(); 767 Variable* shadow = scope()->arguments_shadow();
766 768
(...skipping 9587 matching lines...) Expand 10 before | Expand all | Expand 10 after
10354 memcpy(chunk->GetStartAddress(), desc.buffer, desc.instr_size); 10356 memcpy(chunk->GetStartAddress(), desc.buffer, desc.instr_size);
10355 CPU::FlushICache(chunk->GetStartAddress(), desc.instr_size); 10357 CPU::FlushICache(chunk->GetStartAddress(), desc.instr_size);
10356 return FUNCTION_CAST<MemCopyFunction>(chunk->GetStartAddress()); 10358 return FUNCTION_CAST<MemCopyFunction>(chunk->GetStartAddress());
10357 } 10359 }
10358 10360
10359 #undef __ 10361 #undef __
10360 10362
10361 } } // namespace v8::internal 10363 } } // namespace v8::internal
10362 10364
10363 #endif // V8_TARGET_ARCH_IA32 10365 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.h ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698