Add wrapper script for easy signing of firmware

Add wrapper script for easy signing of firmware

Thought I might as well put this is in the repo since I use it very often.

Change-Id: Iecbb2340dce1522b15aab8eefb3b2c346cb7c24f

BUG=none
TEST=manually signed an image.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=61388bb

[scottz-goog, 2011-03-15 02:51:34]

I say LGTM but some clarity on the variables I pointed out would be preferred
unless they are really that obvious :)

http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
File scripts/image_signing/sign_firmware.sh (right):

http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
scripts/image_signing/sign_firmware.sh:3: # Copyright (c) 2010 The Chromium OS
Authors. All rights reserved.
2011

http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
scripts/image_signing/sign_firmware.sh:22: echo "Usage: $0 <input_fd> <key_dir>
<output_fd>"
fd? maybe this is obvious but I am totally just thinking file descriptor.

http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
scripts/image_signing/sign_firmware.sh:29: # Replace the root key in the GBB
GBB? again most likely obvious..

[gauravsh, 2011-03-15 19:11:23]

You are not going to like this, but I actually agree with your
comments. PTAL again.

On Mon, Mar 14, 2011 at 7:51 PM,  <scottz@google.com> wrote:
> I say LGTM but some clarity on the variables I pointed out would be
> preferred
> unless they are really that obvious :)
>
>
>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
> File scripts/image_signing/sign_firmware.sh (right):
>
>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
> scripts/image_signing/sign_firmware.sh:3: # Copyright (c) 2010 The
> Chromium OS Authors. All rights reserved.
> 2011
>
>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
> scripts/image_signing/sign_firmware.sh:22: echo "Usage: $0 <input_fd>
> <key_dir> <output_fd>"
> fd? maybe this is obvious but I am totally just thinking file
> descriptor.
>
>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
> scripts/image_signing/sign_firmware.sh:29: # Replace the root key in the
> GBB
> GBB? again most likely obvious..
>
> http://codereview.chromium.org/6698014/
>



-- 
-g

[gauravsh, 2011-03-16 01:30:11]

I am going to take your provisional LGTM and push this for now. Let me
know if you have other suggestions/comments, and I can create a
separate CL to fix that.

On Tue, Mar 15, 2011 at 12:11 PM, Gaurav Shah <gauravsh@chromium.org> wrote:
> You are not going to like this, but I actually agree with your
> comments. PTAL again.
>
> On Mon, Mar 14, 2011 at 7:51 PM,  <scottz@google.com> wrote:
>> I say LGTM but some clarity on the variables I pointed out would be
>> preferred
>> unless they are really that obvious :)
>>
>>
>>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
>> File scripts/image_signing/sign_firmware.sh (right):
>>
>>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
>> scripts/image_signing/sign_firmware.sh:3: # Copyright (c) 2010 The
>> Chromium OS Authors. All rights reserved.
>> 2011
>>
>>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
>> scripts/image_signing/sign_firmware.sh:22: echo "Usage: $0 <input_fd>
>> <key_dir> <output_fd>"
>> fd? maybe this is obvious but I am totally just thinking file
>> descriptor.
>>
>>
http://codereview.chromium.org/6698014/diff/2001/scripts/image_signing/sign_f...
>> scripts/image_signing/sign_firmware.sh:29: # Replace the root key in the
>> GBB
>> GBB? again most likely obvious..
>>
>> http://codereview.chromium.org/6698014/
>>
>
>
>
> --
> -g
>



-- 
-g

[scottz-goog, 2011-03-16 16:50:49]

LGTM thanks for updating the names.