Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/proto/event.proto

Issue 6697024: client-side wheel mouse support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unused usings Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/event_executor_win.cc ('K') | « remoting/host/event_executor_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/proto/event.proto
diff --git a/remoting/proto/event.proto b/remoting/proto/event.proto
index 2098e70861d5f8bf5891b7d6a75dd7b862d51ad8..12db9fa7070bb045b2e1c055a421f684864a6433 100644
--- a/remoting/proto/event.proto
+++ b/remoting/proto/event.proto
@@ -11,7 +11,6 @@ option optimize_for = LITE_RUNTIME;
package remoting.protocol;
// Defines a keyboard event.
-// NEXT ID: 3
message KeyEvent {
// The POSIX key code.
required int32 keycode = 1;
@@ -34,6 +33,9 @@ message MouseEvent {
optional int32 y = 2;
// Mouse wheel information.
+ // These values encode the number of wheel 'ticks' (or 'clicks').
Wez 2011/10/13 00:38:01 nit: Consider explaining that "ticks" is the most
garykac 2011/10/13 21:18:53 Done.
+ // TODO(garykac): Add support for high-resolution devices that give
+ // 'delta's that are accumulated to make a single tick.
Wez 2011/10/13 00:38:01 nit: Remove the TODO, and instead just say "We may
garykac 2011/10/13 21:18:53 Done.
optional int32 wheel_offset_x = 3;
optional int32 wheel_offset_y = 4;
« remoting/host/event_executor_win.cc ('K') | « remoting/host/event_executor_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698