client-side wheel mouse support

remoting/client/plugin/pepper_input_handler.cc

Index: remoting/client/plugin/pepper_input_handler.cc
diff --git a/remoting/client/plugin/pepper_input_handler.cc b/remoting/client/plugin/pepper_input_handler.cc
index e07ff43cd7571417fd223f3b61ad9c695dbf1504..6b433c9ab736b07dc65981b62596998ba66c661a 100644
--- a/remoting/client/plugin/pepper_input_handler.cc
+++ b/remoting/client/plugin/pepper_input_handler.cc
@@ -10,9 +10,6 @@
 
 namespace remoting {
 
-using pp::KeyboardInputEvent;
-using pp::MouseInputEvent;
-using protocol::KeyEvent;
 using protocol::MouseEvent;
 
 PepperInputHandler::PepperInputHandler(ClientContext* context,
@@ -78,4 +75,11 @@ void PepperInputHandler::HandleMouseButtonEvent(
   }
 }
 
+void PepperInputHandler::HandleMouseWheelEvent(
+    const pp::WheelInputEvent& event) {
+  pp::FloatPoint ticks = event.GetTicks();
+  SendMouseWheelEvent(static_cast<int>(ticks.x()),

[Wez, 2011/10/13 00:38:01]

Do we really want to static_cast<int>() these?  Won't we lose data?

[Lambros, 2011/10/13 01:10:23]

I'm curious to know why these are floats in the first place.  I wonder if we
should round to nearest int, rather than round down (which I think is what the
cast would do)?

[Wez, 2011/10/13 01:20:05]

Looking at the spec for GetTicks(), it seems that the intent is for fractional
tick values to be accumulated until an integer number of ticks is reached, so
yes, I think this needs changing.

Sorry, Gary!

[garykac, 2011/10/13 21:18:53]

In practice, for a scroll wheel these are always ints represented as floats.

High-resolution input devices may have non-integral values here. These will need
to be stored in a separate field and accumulated on the host (unless we want to
send a float across the wire). Support for that will be in a follow-up CL.

[garykac, 2011/10/13 21:18:53]

They're always integral values (stored as a float) for the cases we currently
care about.

[garykac, 2011/10/13 21:18:53]

Done.

+                      static_cast<int>(ticks.y()));
+}
+
 }  // namespace remoting