Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: remoting/proto/event.proto

Issue 6697024: client-side wheel mouse support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/proto/event.proto
diff --git a/remoting/proto/event.proto b/remoting/proto/event.proto
index 945d0b0e27175ba911d5ddc44608dbf52bae4d26..d575eb8582fa5371d284ad3aca53c824344fbc29 100644
--- a/remoting/proto/event.proto
+++ b/remoting/proto/event.proto
@@ -11,7 +11,6 @@ option optimize_for = LITE_RUNTIME;
package remoting.protocol;
// Defines a keyboard event.
-// NEXT ID: 3
message KeyEvent {
// The POSIX key code.
required int32 keycode = 1;
@@ -33,8 +32,16 @@ message MouseEvent {
optional int32 y = 2;
// Mouse wheel information.
+ // In general, the |offset| values are the most useful, but the raw |clicks|
+ // value can be useful when cycling through a small set of items.
Jamie 2011/03/16 11:59:29 I don't understand what this comment means. How wo
garykac 2011/03/16 20:43:43 If you're doing scrolling, then you should use the
+ // The number of pixels to scroll.
optional int32 wheel_offset_x = 3;
optional int32 wheel_offset_y = 4;
+ // The number of wheel clicks.
+ optional int32 wheel_clicks_x = 7;
+ optional int32 wheel_clicks_y = 8;
+ // True if |offset| values mean scroll by page (rather than by pixel or line).
Jamie 2011/03/16 11:59:29 Why do we have a bool to indicate scrolling by a p
garykac 2011/03/16 20:43:43 The pixel vs. line distinction is app-specific. I
+ optional bool wheel_by_page = 9;
// Mouse button event.
optional MouseButton button = 5;
« remoting/client/input_handler.cc ('K') | « remoting/client/plugin/pepper_input_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698