client-side wheel mouse support

remoting/host/event_executor_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/event_executor.h"
 
 #include <windows.h>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 109 matching lines @@
 
   if (event.has_wheel_offset_x() && event.has_wheel_offset_y()) {
     INPUT wheel;
     wheel.type = INPUT_MOUSE;
     wheel.mi.time = 0;
 
     int dx = event.wheel_offset_x();
     int dy = event.wheel_offset_y();
 
     if (dx != 0) {
-      wheel.mi.mouseData = dx;
+      wheel.mi.mouseData = dx * WHEEL_DELTA;

[Wez, 2011/10/13 00:38:01]

Do we need to worry about overflow here?

[garykac, 2011/10/13 21:18:53]

mouseData is a DWORD
WHEEL_DELTA is 120
dx is typically 1 or -1 (I've never seen other values).

So I don't think it's worth worrying about.

       wheel.mi.dwFlags = MOUSEEVENTF_HWHEEL;
       SendInput(1, &wheel, sizeof(INPUT));
     }
     if (dy != 0) {
-      wheel.mi.mouseData = dy;
+      wheel.mi.mouseData = dy * WHEEL_DELTA;
       wheel.mi.dwFlags = MOUSEEVENTF_WHEEL;
       SendInput(1, &wheel, sizeof(INPUT));
     }
   }
 
   if (event.has_button() && event.has_button_down()) {
     INPUT button_event;
     button_event.type = INPUT_MOUSE;
     button_event.mi.time = 0;
     button_event.mi.dx = 0;
@@ skipping 20 matching lines @@
 }
 
 }  // namespace
 
 EventExecutor* EventExecutor::Create(MessageLoop* message_loop,
                                      Capturer* capturer) {
   return new EventExecutorWin(message_loop, capturer);
 }
 
 }  // namespace remoting