net/ftp/ftp_directory_listing_parser_vms.cc - Issue 6697021: FTP: use ICU to parse month abbreviations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_parser_vms.cc

Issue 6697021: FTP: use ICU to parse month abbreviations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed the comments Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_directory_listing_parser_vms.cc

diff --git a/net/ftp/ftp_directory_listing_parser_vms.cc b/net/ftp/ftp_directory_listing_parser_vms.cc

index c74dad031c2fd85df5a5d7d0a090e3b2835301ac..3047a2a15eb6ada5759bf24a0cc50deaf72ed78c 100644

--- a/net/ftp/ftp_directory_listing_parser_vms.cc

+++ b/net/ftp/ftp_directory_listing_parser_vms.cc

@@ -130,7 +130,7 @@ bool VmsDateListingToTime(const std::vector<string16>& columns,

return false;

if (!base::StringToInt(date_parts[0], &time_exploded.day_of_month))

return false;

- if (!net::FtpUtil::ThreeLetterMonthToNumber(date_parts[1],

+ if (!net::FtpUtil::AbbreviatedMonthToNumber(date_parts[1],

&time_exploded.month))

return false;

if (!base::StringToInt(date_parts[2], &time_exploded.year))

« no previous file with comments | « no previous file | net/ftp/ftp_util.h » ('j') | net/ftp/ftp_util.cc » ('J')