content/common/file_path_watcher/file_path_watcher.h - Issue 6697020: Fixed shutdown concurrency issues in FilePathWatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/file_path_watcher/file_path_watcher.h

Issue 6697020: Fixed shutdown concurrency issues in FilePathWatcher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Tested and updated after changes from 6670081 Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/file_path_watcher/file_path_watcher.h

diff --git a/content/common/file_path_watcher/file_path_watcher.h b/content/common/file_path_watcher/file_path_watcher.h

index 7c784a8bc44fa9777ace5c93f5d1957069a2ee85..8d73b786e69559bdd7e10f3ac1e3f7cc3646c313 100644

--- a/content/common/file_path_watcher/file_path_watcher.h

+++ b/content/common/file_path_watcher/file_path_watcher.h

@@ -40,6 +40,8 @@ class FilePathWatcher {

// by the Mac implementation right now, and must be backed by a CFRunLoop

// based MessagePump. This is usually going to be a MessageLoop of type

// TYPE_UI.

+ // OnFilePathChanged() will be called on the same thread as Watch() is called,

+ // which should have a MessageLoop of TYPE_IO.

bool Watch(const FilePath& path,

Delegate* delegate,

base::MessageLoopProxy* loop) WARN_UNUSED_RESULT;