Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 6697012: Remove 'off the record' references from ChromeURLContext. (Closed)

Created:
9 years, 9 months ago by Vipul
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove 'off the record' references from ChromeURLContext. BUG=3333 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78246

Patch Set 1 #

Patch Set 2 : Removed 'off the record' references from ChromeURLRequestContext. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/extensions/extension_protocols.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Vipul
Renamed ChromeURLContext::off_the_record to ChromeURLContext::incognito Updated getter, setter, and references to them.
9 years, 9 months ago (2011-03-15 02:36:12 UTC) #1
Vipul
Revised classname: Renamed ChromeURLRequestContext::off_the_record to ChromeURLRequestContext::incognito Updated getter, setter, and references to them.
9 years, 9 months ago (2011-03-15 02:39:53 UTC) #2
eroman
LGTM
9 years, 9 months ago (2011-03-15 02:41:33 UTC) #3
Vipul
eroman: Can you run it through the try server and commit it on my behalf ...
9 years, 9 months ago (2011-03-15 03:06:14 UTC) #4
eroman
yeah
9 years, 9 months ago (2011-03-15 03:10:15 UTC) #5
commit-bot: I haz the power
9 years, 9 months ago (2011-03-15 19:22:36 UTC) #6
Change committed as 78246

Powered by Google App Engine
This is Rietveld 408576698