Issue 6696102: Disable SSLUITest.TestCloseTabWithUnsafePopup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6696102: Disable SSLUITest.TestCloseTabWithUnsafePopup (Closed)

Created:
9 years, 9 months ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
cbentzel, jcivelli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable SSLUITest.TestCloseTabWithUnsafePopup BUG=77374 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79512

Patch Set 2 : Fix typo #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ssl/ssl_browser_tests.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cbentzel

LGTM http://codereview.chromium.org/6696102/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): http://codereview.chromium.org/6696102/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode764 chrome/browser/ssl/ssl_browser_tests.cc:764: // Previsouly marked as flaky: http://crbug.com/40932 Nit: Previously

9 years, 9 months ago (2011-03-25 09:55:07 UTC) #2

jcivelli

9 years, 9 months ago (2011-03-28 16:22:10 UTC) #3

LGTM



On Fri, Mar 25, 2011 at 2:55 AM, <cbentzel@chromium.org> wrote:

> LGTM
>
>
>
>
http://codereview.chromium.org/6696102/diff/1/chrome/browser/ssl/ssl_browser_...
> File chrome/browser/ssl/ssl_browser_tests.cc (right):
>
>
>
http://codereview.chromium.org/6696102/diff/1/chrome/browser/ssl/ssl_browser_...
> chrome/browser/ssl/ssl_browser_tests.cc:764: // Previsouly marked as
>
> flaky: http://crbug.com/40932
> Nit: Previously
>
>
> http://codereview.chromium.org/6696102/
>

Expand Messages | Collapse Messages

Issue 6696102: Disable SSLUITest.TestCloseTabWithUnsafePopup (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typo #

Messages