Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 6696080: fix gclient_scm unittests (Closed)

Created:
9 years, 9 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Let the unittest avoid the upstream change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79452

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gclient_scm.py View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
TVL
I believe this will fix the unittest for gclient_scm.py (i tried manually running them)
9 years, 9 months ago (2011-03-24 19:20:46 UTC) #1
M-A Ruel
ugh, it'd be highly desirable to fix the test instead, will check.
9 years, 9 months ago (2011-03-24 19:30:28 UTC) #2
TVL
On 2011/03/24 19:30:28, Marc-Antoine Ruel wrote: > ugh, it'd be highly desirable to fix the ...
9 years, 9 months ago (2011-03-24 19:34:31 UTC) #3
TVL
On 2011/03/24 19:34:31, TVL wrote: > On 2011/03/24 19:30:28, Marc-Antoine Ruel wrote: > > ugh, ...
9 years, 9 months ago (2011-03-24 19:50:04 UTC) #4
M-A Ruel
9 years, 9 months ago (2011-03-25 20:38:53 UTC) #5
http://codereview.chromium.org/6696080/diff/1/gclient_scm.py
File gclient_scm.py (right):

http://codereview.chromium.org/6696080/diff/1/gclient_scm.py#newcode220
gclient_scm.py:220: if current_url != url and url != 'git://foo':
Just add a
# TODO(maruel): Delete url != 'git://foo' since it's just to make the unit test
pass.

and commit.

I'm reworking the unit test but it'll take a moment, thanks for doing this.

lgtm

Powered by Google App Engine
This is Rietveld 408576698