chrome/renderer/print_web_view_helper_mac.mm - Issue 6696076: Adding CreateFromData to NativeMetafileFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_mac.mm

Issue 6696076: Adding CreateFromData to NativeMetafileFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing comments, fixing mac unitests. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/print_web_view_helper_mac.mm

diff --git a/chrome/renderer/print_web_view_helper_mac.mm b/chrome/renderer/print_web_view_helper_mac.mm

index 2ef74d3fe63e527aca82533a2c7c07f1bfec0d22..8058ab5db765cf46327dcfde8885afe5f3bc681e 100644

--- a/chrome/renderer/print_web_view_helper_mac.mm

+++ b/chrome/renderer/print_web_view_helper_mac.mm

@@ -20,8 +20,7 @@ void PrintWebViewHelper::PrintPage(const PrintMsg_PrintPage_Params& params,

WebFrame* frame) {

scoped_ptr<printing::NativeMetafile> metafile(

printing::NativeMetafileFactory::Create());

- if (!metafile->Init())

- return;

+ CHECK(metafile.get());

vandebo (ex-Chrome) 2011/03/24 21:21:58 Doing the same thing as before is fine here - retu

dpapad 2011/03/24 22:02:37 Done.

float scale_factor = frame->getPrintPageShrink(params.page_number);

int page_number = params.page_number;

@@ -67,8 +66,7 @@ void PrintWebViewHelper::CreatePreviewDocument(

scoped_ptr<printing::NativeMetafile> metafile(

printing::NativeMetafileFactory::Create());

- if (!metafile->Init())

- return;

+ CHECK(metafile.get());

vandebo (ex-Chrome) 2011/03/24 21:21:58 And here.

dpapad 2011/03/24 22:02:37 Done.

float scale_factor = frame->getPrintPageShrink(0);

gfx::Point origin(printParams.margin_left, printParams.margin_top);