Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 6696067: Make V8 build with the chromium shared library build (Closed)

Created:
9 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make V8 build with the chromium shared library build Fix the shell to not use functions from the v8::internal namespace when building with V8 in a shared library. Remove the v8_preparser library. The dependencies for this target needs to be resolved after isolates have landed. Committed: http://code.google.com/p/v8/source/detail?r=7337

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -40 lines) Patch
M samples/shell.cc View 1 2 7 chunks +35 lines, -8 lines 1 comment Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
9 years, 9 months ago (2011-03-24 09:40:10 UTC) #1
Mads Ager (chromium)
Urgh. Can you file a bug on the preparser thing. Lasse was looking into getting ...
9 years, 9 months ago (2011-03-24 10:59:03 UTC) #2
Mads Ager (chromium)
9 years, 9 months ago (2011-03-24 10:59:23 UTC) #3
And LGTM as a temporary fix.

Powered by Google App Engine
This is Rietveld 408576698