Issue 6696067: Make V8 build with the chromium shared library build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6696067: Make V8 build with the chromium shared library build (Closed)

Created:
9 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make V8 build with the chromium shared library build Fix the shell to not use functions from the v8::internal namespace when building with V8 in a shared library. Remove the v8_preparser library. The dependencies for this target needs to be resolved after isolates have landed. Committed: http://code.google.com/p/v8/source/detail?r=7337

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 9 years, 9 months ago

		Unified diffs	Side-by-side diffs	Stats (+35 lines, -40 lines)
	M	samples/shell.cc	View	7 chunks	+35 lines, -8 lines	1 comment
	M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -32 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Urgh. Can you file a bug on the preparser thing. Lasse was looking into getting ...

9 years, 9 months ago (2011-03-24 10:59:03 UTC) #2

And LGTM as a temporary fix.

Expand Messages | Collapse Messages