src/platform-solaris.cc - Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform-solaris.cc

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates

Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/platform-solaris.cc

diff --git a/src/platform-solaris.cc b/src/platform-solaris.cc

index b484c819af9782f06974ceb1cca8fe2b002b2c3b..6e66512841b8526b0d5c21e90741a70bdb0f2c88 100644

--- a/src/platform-solaris.cc

+++ b/src/platform-solaris.cc

@@ -169,7 +169,7 @@ void* OS::Allocate(const size_t requested,

void* mbase = mmap(NULL, msize, prot, MAP_PRIVATE | MAP_ANON, -1, 0);

if (mbase == MAP_FAILED) {

- LOG(StringEvent("OS::Allocate", "mmap failed"));

+ LOG(ISOLATE, StringEvent("OS::Allocate", "mmap failed"));

return NULL;

}

*allocated = msize;

« no previous file with comments | « src/platform-openbsd.cc ('k') | src/platform-win32.cc » ('j') | no next file with comments »