Issue 6695029: Make ContentBrowserClient not be owned by ContentClient, so that the latter d...

Issue 6695029: Make ContentBrowserClient not be owned by ContentClient, so that the latter d... (Closed)

Created:
9 years, 9 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make ContentBrowserClient not be owned by ContentClient, so that the latter doesn't have to include a header from the former. Also tighten up DEPS checking so that we ensure that content\common doesn't depend on any other content directory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78273

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -17 lines)			Patch
M	chrome/browser/browser_main.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_content_client.h	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View		1 chunk	+3 lines, -0 lines	2 comments	Download
M	chrome/test/browser_with_test_window_test.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/test/browser_with_test_window_test.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	content/DEPS	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	content/browser/DEPS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/content_client.h	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	content/worker/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Looks like you covered all the places we create it-- LGTM. http://codereview.chromium.org/6695029/diff/16/chrome/common/chrome_content_client.cc File chrome/common/chrome_content_client.cc (right): ...

9 years, 9 months ago (2011-03-15 20:15:00 UTC) #2

jam

9 years, 9 months ago (2011-03-15 20:25:24 UTC) #3

http://codereview.chromium.org/6695029/diff/16/chrome/common/chrome_content_c...
File chrome/common/chrome_content_client.cc (right):

http://codereview.chromium.org/6695029/diff/16/chrome/common/chrome_content_c...
chrome/common/chrome_content_client.cc:19: }
On 2011/03/15 20:15:00, creis wrote:
> Any reason to add this now, if we're not doing anything with it (or even
calling
> it) yet?

I just had it in the same checkout, so I figured it doesn't hurt to keep it..

Expand Messages | Collapse Messages