Issue 6695018: Follow Safari on not throwing when __defineGetter__ fails....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6695018: Follow Safari on not throwing when defineGetter fails.... (Closed)

Created:
9 years, 9 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Follow Safari on not throwing when __defineGetter__ fails. In addition, this fixes defineOwnProperty to actually not throw when the should_throw flag is false (we had no usage of this priorly). Committed: http://code.google.com/p/v8/source/detail?r=7176

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -65 lines)			Patch
M	src/v8natives.js	View	4 chunks	+39 lines, -10 lines	0 comments	Download
M	test/mjsunit/regress/regress-1240.js	View	1 chunk	+2 lines, -49 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

OK, LGTM