Chromium Code Reviews

Issue 6695018: Follow Safari on not throwing when __defineGetter__ fails.... (Closed)

Created:
9 years, 9 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Lasse Reichstein, Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Follow Safari on not throwing when __defineGetter__ fails. In addition, this fixes defineOwnProperty to actually not throw when the should_throw flag is false (we had no usage of this priorly). Committed: http://code.google.com/p/v8/source/detail?r=7176

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+41 lines, -65 lines)
M src/v8natives.js View 4 chunks +39 lines, -10 lines 0 comments
M test/mjsunit/regress/regress-1240.js View 1 chunk +2 lines, -49 lines 0 comments
M test/mozilla/mozilla.status View 1 chunk +0 lines, -6 lines 0 comments

Messages

Total messages: 3 (0 generated)
Rico
9 years, 9 months ago (2011-03-15 13:28:15 UTC) #1
Rico
Adding Mads, Lasse left
9 years, 9 months ago (2011-03-15 14:14:09 UTC) #2
Mads Ager (chromium)
9 years, 9 months ago (2011-03-15 14:17:50 UTC) #3
OK, LGTM

Powered by Google App Engine