Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: printing/emf_win.h

Issue 6695013: Cleanup NativeMetafile (win) interface and EMF class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/plugin/webplugin_delegate_stub.cc ('k') | printing/emf_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/emf_win.h
diff --git a/printing/emf_win.h b/printing/emf_win.h
index f2ccffd1235540fa165734e0e6b77f0aca031007..f4ee30f16af0536dd52c7e1f6caa070f2d1c26eb 100644
--- a/printing/emf_win.h
+++ b/printing/emf_win.h
@@ -29,10 +29,20 @@ class Emf : public NativeMetafile {
class Enumerator;
struct EnumerationContext;
+ // Generates a virtual HDC that will record every GDI commands and compile
+ // it in a EMF data stream.
+ Emf();
virtual ~Emf();
+ // Generates a new metafile that will record every GDI command, and will
+ // be saved to |metafile_path|.
+ virtual bool InitToFile(const FilePath& metafile_path);
+
+ // Initializes the Emf with the data in |metafile_path|.
+ virtual bool InitFromFile(const FilePath& metafile_path);
+
// NativeMetafile methods.
- virtual bool Init() { return true; }
+ virtual bool Init();
virtual bool InitFromData(const void* src_buffer, uint32 src_buffer_size);
virtual skia::PlatformDevice* StartPageForVectorCanvas(
@@ -68,14 +78,6 @@ class Emf : public NativeMetafile {
return hdc_;
}
- virtual bool CreateDc(HDC sibling, const RECT* rect);
- virtual bool CreateFileBackedDc(HDC sibling,
- const RECT* rect,
- const FilePath& path);
- virtual bool CreateFromFile(const FilePath& file_path);
-
- virtual void CloseEmf();
-
virtual bool Playback(HDC hdc, const RECT* rect) const;
virtual bool SafePlayback(HDC hdc) const;
@@ -85,16 +87,7 @@ class Emf : public NativeMetafile {
return emf_;
}
- protected:
- Emf();
-
private:
- friend class NativeMetafileFactory;
- FRIEND_TEST_ALL_PREFIXES(EmfTest, DC);
- FRIEND_TEST_ALL_PREFIXES(EmfTest, FileBackedDC);
- FRIEND_TEST_ALL_PREFIXES(EmfPrintingTest, Enumerate);
- FRIEND_TEST_ALL_PREFIXES(EmfPrintingTest, PageBreak);
-
// Playbacks safely one EMF record.
static int CALLBACK SafePlaybackProc(HDC hdc,
HANDLETABLE* handle_table,
« no previous file with comments | « content/plugin/webplugin_delegate_stub.cc ('k') | printing/emf_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698