Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 6695012: Add function for VDAT processing. (Closed)

Created:
9 years, 9 months ago by vb
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add function for VDAT processing. This CL is a user space counterpart of http://codereview.chromium.org/6690023, which provided the ability to retrieve buffers through chromeos_acpi driver. The buffer contents is communicated as a multi line string with each buffer byte represented as a two symbol hex number. `crosstool', on the other has to map the buffer contents into a certain binary structure. This CL add conversion of the multiline string into a binary buffer and also adds a temp. routine to dump the buffer contents on the screen when `crosstool' is invoked. Change-Id: I8dd3eb935332f9bc8769c71de0db302365f12d70 BUG=chromium-os:13069, chromium-os:13091 TEST=manual - Install the new image on a target with firmware providing the VDAT ACPI method. - Run crosstool and watch for the last line: vdat = 11 22 33 44 ff 1f 1c 40 ff 57 74 41 ff ff ff ff # Raw VDAT contents. localhost tmp # Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2008423

Patch Set 1 : Add code to parse ACPI buffers. #

Total comments: 4

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -0 lines) Patch
M host/lib/crossystem.c View 1 6 chunks +134 lines, -0 lines 0 comments Download
M utility/crossystem_main.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vb
9 years, 9 months ago (2011-03-15 02:03:24 UTC) #1
Randall Spangler
LGTM; minor nits. http://codereview.chromium.org/6695012/diff/2001/host/lib/crossystem.c File host/lib/crossystem.c (right): http://codereview.chromium.org/6695012/diff/2001/host/lib/crossystem.c#newcode315 host/lib/crossystem.c:315: FILE *f = NULL; Shouldn't these ...
9 years, 9 months ago (2011-03-15 05:32:16 UTC) #2
vb
9 years, 9 months ago (2011-03-15 16:31:30 UTC) #3
committed

http://codereview.chromium.org/6695012/diff/2001/host/lib/crossystem.c
File host/lib/crossystem.c (right):

http://codereview.chromium.org/6695012/diff/2001/host/lib/crossystem.c#newcod...
host/lib/crossystem.c:315: FILE *f = NULL;
On 2011/03/15 05:32:16, Randall Spangler wrote:
> Shouldn't these be 'FILE* f'?

changed to match the file style.

http://codereview.chromium.org/6695012/diff/2001/host/lib/crossystem.c#newcod...
host/lib/crossystem.c:677: *  string. It is expected to be replaced with
afunction which has knowledge
On 2011/03/15 05:32:16, Randall Spangler wrote:
> a function

Done.

Powered by Google App Engine
This is Rietveld 408576698